-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/step-ca: Adding module for step-ca. #110822
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Jan 25, 2021
midchildan
suggested changes
Jan 26, 2021
midchildan
reviewed
Jan 26, 2021
mohe2015
force-pushed
the
module/step-ca
branch
2 times, most recently
from
January 27, 2021 20:55
03d28c3
to
311f8fd
Compare
mohe2015
commented
Jan 27, 2021
Co-authored-by: Moritz Hedtke <[email protected]>
mohe2015
force-pushed
the
module/step-ca
branch
from
January 27, 2021 21:08
311f8fd
to
ddd8849
Compare
10 tasks
Hey thanks for finishing up the last twiddly bits here @midchildan and @mohe2015! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: module (update)
This PR changes an existing module in `nixos/`
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
10.rebuild-linux: 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First @Church- are you fine with this? I kept you as an author but added myself as a co-author.
@midchildan you also gave feedback on the original pull request. Would you like to give some again?
Motivation for this change
#97225 stalled and there is no local certificate authoritiy which can e.g. be used instead of letsencrypt for local deployments or testing.
Things done
Edit: I will fix the EditorStyle complaints tomorrow (and also the TODOs that are easy to fix)
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)