Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/step-ca: Adding module for step-ca. #110822

Closed
wants to merge 1 commit into from

Conversation

mohe2015
Copy link
Contributor

@mohe2015 mohe2015 commented Jan 25, 2021

First @Church- are you fine with this? I kept you as an author but added myself as a co-author.
@midchildan you also gave feedback on the original pull request. Would you like to give some again?

Motivation for this change

#97225 stalled and there is no local certificate authoritiy which can e.g. be used instead of letsencrypt for local deployments or testing.

Things done

nixos: Adding module for step-ca, set up by default to allow for both regular x.509 certs and SSH certs as well.
Also add a possibility for ACME and implement systemd hardening. Addressed all feedback from the original PR.

Edit: I will fix the EditorStyle complaints tomorrow (and also the TODOs that are easy to fix)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 25, 2021
nixos/modules/services/security/step-ca.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/step-ca.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/step-ca.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/step-ca.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/step-ca.nix Outdated Show resolved Hide resolved
nixos/modules/services/security/step-ca.nix Outdated Show resolved Hide resolved
@Church-
Copy link

Church- commented Feb 14, 2021

Hey thanks for finishing up the last twiddly bits here @midchildan and @mohe2015!

@mohe2015
Copy link
Contributor Author

mohe2015 commented Feb 14, 2021

@Church- Sure, we currently plan to use a bit different approach #112322 btw.

@mohe2015 mohe2015 deleted the module/step-ca branch April 17, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants